Do not allow asymmetric tables in pbs #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
approved these changes
Sep 14, 2022
| @@ -80,7 +80,7 @@ class ObjectSchema { | |||
| bool property_is_computed(Property const& property) const noexcept; | |||
|
|
|||
| void validate(Schema const& schema, std::vector<ObjectSchemaValidationException>& exceptions, | |||
| bool for_sync) const; | |||
| uint64_t validation_mode) const; | |||
There was a problem hiding this comment.
Can this take a SchemaValidationMode rather than a uint64_t?
danieltabacaru
force-pushed
the
dt/do_not_allow_asymmetric_objects_in_pbs
branch
from
436bb0f
to
e38ad5f
Compare
danieltabacaru
deleted the
dt/do_not_allow_asymmetric_objects_in_pbs
branch
tgoyne
added a commit
that referenced
this pull request
Sep 16, 2022
…nification * origin/master: Stop forcing enums to be 64 bits unnecessarily clean up documentation of internal fields in config structs SyncConfig should be default constructible Traversal functions use IteratorControl values rather than true/false which is more expressive (#5857) Fix handling of 4-byte UTF8 values on Windows (#5803) Encode links in a way the server can understand (#5835) expose `Group::remove_table` in the C API (#5860) Disable auto refresh for old realm during migration (#5856) Expose `list_find` in the c api (#5848) Do not allow asymmetric tables in pbs (#5853) Refactor link tracing code (#5796) Expose `Obj::get_parent_object` in the C API (#5851) Update app.hpp (#5854) Fix appending to list ignores existing query (#5850)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Do not allow asymmetric tables in schemas when using partition based sync.
Fixes #5691.
☑️ ToDos